Cleanup hexdump code #1279
Merged
Cleanup hexdump code #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsingh93
force-pushed
the
hexdump
branch
2 times, most recently
from
8680e94
to
c5aa66e
Compare
gsingh93
commented
Oct 13, 2022
| @@ -13,7 +13,7 @@ | |||
| pwndbg.config.Parameter("hexdump-bytes", 64, "number of bytes printed by hexdump command") | |||
| pwndbg.config.Parameter( | |||
| "hexdump-group-width", | |||
| 4, | |||
| -1, | |||
There was a problem hiding this comment.
Any objections to this?
There was a problem hiding this comment.
Not really, I think it is fine
Codecov Report
@@ Coverage Diff @@
## dev #1279 +/- ##
==========================================
- Coverage 55.28% 55.26% -0.03%
==========================================
Files 185 185
Lines 20324 20317 -7
Branches 1884 1881 -3
==========================================
- Hits 11237 11229 -8
- Misses 8658 8660 +2
+ Partials 429 428 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup of the
hexdumpcode. Also sets the default group width to -1, which is the architecture pointer size.