Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instr operands padding in enhance #1372

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

arcz
Copy link
Contributor

@arcz arcz commented Nov 11, 2022

The current display of instructions outside DISASM window adds padding before operands however it doesn't serve any purpose. This PR removed this padding.

Before:
Screenshot from 2022-11-11 17-15-26

After:
Screenshot from 2022-11-11 17-15-49

@codecov-commenter
Copy link

Codecov Report

Merging #1372 (198b5bc) into dev (dd64540) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1372   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         155      155           
  Lines       19576    19576           
  Branches     1839     1839           
=======================================
  Hits        11378    11378           
  Misses       7636     7636           
  Partials      562      562           
Impacted Files Coverage Δ
pwndbg/enhance.py 85.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsingh93 gsingh93 merged commit 12e8ad8 into pwndbg:dev Nov 11, 2022
@arcz arcz deleted the enhance-instr branch November 11, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants