Deprecate kernel-vmmap-via-page-tables in favor of kernel-vmmap #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1415 +/- ##
==========================================
- Coverage 58.15% 58.13% -0.02%
==========================================
Files 155 155
Lines 19601 19611 +10
Branches 1844 1848 +4
==========================================
+ Hits 11398 11400 +2
- Misses 7643 7651 +8
Partials 560 560
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
disconnect3d
reviewed
Dec 5, 2022
| # these cases in a `finally` block instead of an `except` block. | ||
| if monitor_info_mem is None or "unknown command" in monitor_info_mem: | ||
| # TODO: Find out which other architectures don't support this command | ||
| if pwndbg.gdblib.arch.name == "aarch64": |
There was a problem hiding this comment.
wondering what's the difference; oh i guess current returns some struct
There was a problem hiding this comment.
I think they should be the same thing:
Lines 8 to 10 in f571d5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should be able to completely disable
vmmapwhen debugging kernels, so that issues with gdb-pt-dump ormonitor info memdon't become blockers, and for performance reasons.For
aarch64,monitor info memisn't supported, so we gracefully hand that case and warn the user.Fixes #1403.