command: support alternatives including sub command wrapper like pwn #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthraxx
force-pushed
the
feature/checksec-alternative-pwntools
branch
from
bde67b8
to
e81aacb
Compare
|
welp, rip CI, i need to figure out what that cryptic test mismatch is and why the test binaries fail horribly on the newer travis ubuntu. Maybe @disconnect3d has a hint? |
|
If it helps any, the pwn wrapper is ALWAYS installed.
However, some distros have it as the only binary installed.
On Tue, Jan 28, 2020 at 7:12 PM Levente Polyak ***@***.***> wrote:
welp, rip CI, i need to figure out what that cryptic test mismatch is and
why the test binaries fail horribly on the newer travis ubuntu. Maybe
@disconnect3d <https://github.com/disconnect3d> has a hint?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#701?email_source=notifications&email_token=AAA3IGHM2JZFO3XSYOPREJTRADJWZA5CNFSM4KM4X6A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFTFTQ#issuecomment-579547854>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3IGALECXGZYXLX3BQ2QLRADJWZANCNFSM4KM4X6AQ>
.
--
*Zach Riggle*
|
|
@anthraxx um, that's weird.. maybe some ld.so/libc breaking change? Sounds like we should recompile the binaries. |
|
@disconnect3d yeah looks like that, i was first confused because it reads like travis creates those, but we seem to store them in the tests directory. Can you look into recompiling them against xenial? |
|
@anthraxx Will do, let's skip them for now |
|
Hmm maybe we should introduce the change to xenial in another PR? |
anthraxx
force-pushed
the
feature/checksec-alternative-pwntools
branch
from
e81aacb
to
5fc1925
Compare
|
@disconnect3d yes, i just tried to fix the CI :D pushed without |
Additionally speed up the checksec logic by removing the --version check. Simply try to shell out and use the first working option variant as we can't easily detect the different available alternatives in a bulletproof way. This implementation allows to use the sub command wrapper 'pwn' to call checksec in case pwntools has been installed using --only-use-pwn-command To unconditionally unify the usage, the functions cmd attribute stores the base command to execute in form of a list that can be used to concatenate an array of options against it and pass the final list to call_cmd
Lets try a third available version of checksec as the lowest order variant in our cascade that works by only passing the target file without additional specifier.
anthraxx
force-pushed
the
feature/checksec-alternative-pwntools
branch
from
5fc1925
to
1db95f9
Compare
disconnect3d
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command: support alternatives including sub command wrapper like pwn
Additionally speed up the checksec logic by removing the --version
check. Simply try to shell out and use the first working option variant
as we can't easily detect the different available alternatives in a
bulletproof way.
This implementation allows to use the sub command wrapper 'pwn' to call
checksec in case pwntools has been installed using --only-use-pwn-command
To unconditionally unify the usage, the functions cmd attribute stores
the base command to execute in form of a list that can be used to
concatenate an array of options against it and pass the final list to
call_cmd