Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Backslash #14

wants to merge 2 commits into from

Conversation

aabed
Copy link

@aabed aabed commented Feb 1, 2015

Payload is added to hpfeeds collection with backslashes which results in the keys to be unusable as it's already has been escaped

This change will result into the payload and session to be written without backslashes

@jatrost
Copy link

jatrost commented Feb 1, 2015

This seems like a risky change. If the data is not valid JSON then it will not get stored; hpfeeds allows sensors to send back data in whatever format they want ranging from json to xml to binary data. What are you trying to accomplish with this change (i.e. what is the end goal)?

@aabed
Copy link
Author

aabed commented Feb 2, 2015

there is a sample of the payload record from honeypots right now

"payload" : "{"local_host": "::ffff:41.130.152.160", "local_port":
3306, "connection_type": "accept", "remote_port": 47834,
"remote_host": "::ffff:108.61.199.226", "remote_hostname": "",
"connection_protocol": "mysqld", "connection_transport": "tcp"}",
"channel" : "dionaea.connections" }

I want to remove those '' from the database record to be able to use it
through mongo

On Sun, Feb 1, 2015 at 11:12 PM, Jason Trost notifications@github.com
wrote:

This seems like a risky change. If the data is not valid JSON then it will
not get stored; hpfeeds allows sensors to send back data in whatever format
they want ranging from json to xml to binary data. What are you trying to
accomplish with this change (i.e. what is the end goal)?


Reply to this email directly or view it on GitHub
https://github.com/threatstream/mnemosyne/pull/14#issuecomment-72384446.

@jatrost
Copy link

jatrost commented Feb 7, 2015

What ultimately are you trying to accomplish by removing the back slashes?

I think what ever it is can be done in mnemosyne by writing the data into a new collection (similar to sessions, files, urls, dorks, etc, see https://github.com/threatstream/mnemosyne/tree/master/normalizer/modules), but changing how menmosyne stores all raw messages from hpfeeds will break a lot things in mnemosyne.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants