Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lat / Lon particle output #4

Open
pwolfram opened this issue Aug 17, 2018 · 10 comments
Open

Lat / Lon particle output #4

pwolfram opened this issue Aug 17, 2018 · 10 comments
Labels
enhancement New feature or request Priority

Comments

@pwolfram
Copy link
Owner

Particle output should be reported in latitude and longitude coordinates to facilitate global analysis.

@pwolfram pwolfram added enhancement New feature or request Priority labels Aug 17, 2018
@pwolfram
Copy link
Owner Author

cc @bradyrx @maltrud

@pwolfram
Copy link
Owner Author

pwolfram commented Oct 8, 2018

Resolved by #15.

@pwolfram
Copy link
Owner Author

Closed by #15

@bradyrx
Copy link

bradyrx commented Oct 15, 2018

@pwolfram,

I'm seeing a bug when testing my particle output for this. latParticle seems to be working but not lonParticle.

See below. I select an arbitrary particle number, then manually convert its x/y/z location to lat/lon and check it against the output latParticle/lonParticle.

@pwolfram
Copy link
Owner Author

@bradyrx, great catch. There is a shift in longitude that is needed to correspond to a direct mapping with the mesh, e.g., see be19e75 I needed to add this for consistency with respect to our mesh conversion / coordinate system for the mesh.

If you check for cell centers closest to the particles (which is the metric I used), do you reasonable results? This was how I validated the longitude of the particles.

@pwolfram pwolfram reopened this Oct 15, 2018
@pwolfram
Copy link
Owner Author

@bradyrx, please close (or leave open) until we have this 100% resolved. Thanks!

@bradyrx
Copy link

bradyrx commented Oct 15, 2018

@pwolfram,

Thanks for the feedback and suggestion. Just wanted to vet the simple fixes (i.e. lat/lon/global ID) on my own through python and not just paraview.

See below implementation for verification:

@bradyrx
Copy link

bradyrx commented Oct 15, 2018

@bradyrx, please close (or leave open) until we have this 100% resolved. Thanks!

I think you need to do this since I'm not an assignee. No comment & close option for me.

@pwolfram
Copy link
Owner Author

Thanks!

@pwolfram
Copy link
Owner Author

Consider including in input in particle initialization.

@pwolfram pwolfram reopened this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority
Projects
None yet
Development

No branches or pull requests

2 participants