Setup automated macOS tests using GitHub action #2284
Conversation
|
Is it reasonable to set up a semi-automatic build process for MacOS? |
MattHag
force-pushed
the
macos_test_ci_1244
branch
from
d17a2a1
to
8b35834
Compare
|
Yes, that is implicitly included here. |
|
Can that be put in something like a make file for MacOS? |
|
Yes, both Linux and macOS commands should be moved to the Makefile in a later change. Thus, they can be reused locally. |
|
OK, I'll pull this in now. |
|
@MattHag I noticed you install and start dbus via homebrew in this PR. Is that actually needed? Since we removed dbus-python Solaar isn't actually using anything dbus, right? |
|
Yes it will be at least neceaary for the local setup. |
|
What is it needed for though? dbus seems to only be used for listening to UPower events on Linux which doesn't exist on macos so I see no need for installing dbus on macos? |
|
I needed it to avoid log error messages related to that on solaar startup. Maybe it's just a missing exclusion for macOS in the code. |
|
I would guess those error you saw messages no longer appear now that we have excluded dbus-python from being installed on macos. The only warning you should get is |
|
Okay, then feel free to remove it. |
|
It's your PR man. I'm just helping you out because @pfps asked for it. Nowhere in the instructions for macos does it say to install dbus so you shouldn't have added that in the first place. |
Replaces deprecated Node.js 16 actions. Related pwr-Solaar#2256, pwr-Solaar#2284
* Show pytest coverage in GitHub CI tests Related #1097 * Extend Makefile with installation and test targets Refactor setup steps to unify commands between Linux and macOS. Move bash commands into Makefile for consistency and enable local execution of GitHub CI commands corresponding Makefile targets. Install on Ubuntu: make install_ubuntu Install on Ubuntu for development: make install_ubuntu PIP_ARGS=."[test]" Fixes #2303 * Improve name of GitHub test actions Related #2303 * Upgrade GitHub actions to Node.js 20 Replaces deprecated Node.js 16 actions. Related #2256, #2284
Related #1244