Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try removing peer deps #355

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Try removing peer deps #355

merged 3 commits into from
Apr 26, 2024

Conversation

huntharo
Copy link
Collaborator

@huntharo huntharo commented Apr 25, 2024 •
edited
Loading

  • Add dep between pwrdrvr and microapps-publish
  • Remove peer deps as this didn't appear to work

yarn warnings from peer deps approach

[3/4] 🔗  Linking dependencies...
warning "../microapps-core/packages/pwrdrvr/pwrdrvr-0.0.0.tgz > @aws-sdk/client-sts@3.556.0" has unmet peer dependency "@aws-sdk/credential-provider-node@^3.556.0".
warning " > pwrdrvr@0.0.0" has unmet peer dependency "@aws-sdk/client-lambda@^3.78.0".
warning " > pwrdrvr@0.0.0" has unmet peer dependency "@aws-sdk/client-s3@^3.78.0".
warning " > pwrdrvr@0.0.0" has unmet peer dependency "@aws-sdk/client-sts@^3.78.0".
warning " > pwrdrvr@0.0.0" has unmet peer dependency "@aws-sdk/lib-storage@^3.78.0".

@huntharo huntharo self-assigned this Apr 25, 2024
@huntharo huntharo closed this Apr 25, 2024
@huntharo huntharo reopened this Apr 25, 2024
@huntharo huntharo merged commit abc7c0b into main Apr 26, 2024
11 checks passed
@huntharo huntharo deleted the peer-deps-bad-maybe branch April 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@huntharo huntharo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huntharo