Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Add pyulog to ubuntu_sim_nuttx.sh #239

Closed
CarlOlsson opened this issue Aug 3, 2017 · 5 comments
Closed

Add pyulog to ubuntu_sim_nuttx.sh #239

CarlOlsson opened this issue Aug 3, 2017 · 5 comments

Comments

@CarlOlsson
Copy link

Would be nice if pyulog was included in ubuntu_sim_nuttx.sh

@hamishwillee
Copy link
Collaborator

Hi Carl,

I've tried to keep the stuff in those scripts near-minimal for the developer environment. My concern is that they grow out of of control with whatever people think might be useful for some developer.

That said,

  1. I'm very happy with this if it is explained in the manual setup or possibly as part of "additional tools". Why do you think this should be part of the dev env?
  2. Is this useful only in this script, or would it also be useful to simulation-only users, windows users, snapdragon users etc? If so, we also need to update the other scripts: https://github.com/PX4/Devguide/tree/master/build_scripts.

Make sense?

@CarlOlsson
Copy link
Author

Hi,

Okey yea if the philosophy is to keep the scripts near-minimal then it should not be there, feel free to close here. I proposed to add it since I think the majority of developers will need it. It makes it much easier to quickly analyse logs etc.

Yes if we decide to add it it should for sure be added to all scripts.

@hamishwillee
Copy link
Collaborator

@bkueng What do you think - will the majority of developers want to install pyulog into their development environment?

@bkueng
Copy link
Member

bkueng commented Aug 7, 2017

@bkueng What do you think - will the majority of developers want to install pyulog into their development environment?

We can add it, yes - it's a small package and only has few dependencies. It's especially useful if you want to have a closer look at logs, or convert them to CSV.

@hamishwillee
Copy link
Collaborator

Awesome. OK @CarlOlsson - I have added this as #249 (now merged). If you could give the changes a quick scan, that would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants