Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up precision land flight mode parameters #100

Open
4 tasks
hamishwillee opened this issue Nov 20, 2017 · 2 comments
Open
4 tasks

Fix up precision land flight mode parameters #100

hamishwillee opened this issue Nov 20, 2017 · 2 comments

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 20, 2017

NOTE: This isn't in master yet, so I will add a big fat note on the released docs and put on hold the rest of this for now See PX4/PX4-Autopilot#8160

Precision land was merged in #98 and updated in #99. As part of that the parameters were linked to the full parameter reference. But ...

@ndepal None of the parameters mentioned appear in the parameter reference - e.g. LTEST_MODE, LTEST_SCALE_X, LTEST_SCALE_Y etc.

Can we get them added? Not only does this force proper documentation (exhaustive), but it means that all the links I just added to the reference will actually work :-0.

Actions

  • Make sure that the parameter reference for all precland parameters is generated
  • Update the precland docs to have tabular docs for the main relevant parameters (as per other flight modes)
  • Add either dedicated flight mode doc for this mode, or more likely a link in the top level flight mode docs.
  • Fix doc to make it clear that only the MarkOne beacon can be used. As per Tidy up precland docs #99 (comment)
@ndepal
Copy link
Contributor

ndepal commented Nov 20, 2017

I'm not sure what is required for the parameters to show up there.
I'm guessing one criterion is that the code needs to be in master, which it is no yet.
If the param reference is not generated from the prarams.c, please let me know what needs to be added.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Nov 20, 2017

My fault - this should not be merged until in master. At that point the parameters if present should get picked up. I vote we look at this again once this is merged. IN the meantime I added a note on the topic so people won't try and use it yet!

PS It looks pretty good thanks! I moved things about a bit and tidied the English, but that was a really easy job after your merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants