JSON format with "mcstatus [address] json" #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because JSON format is better for external use.
Need another change to work fine :
in connection.py in classes TCPSocketConnection and UDPSocketConnection :
"def __del__(self):
try:
self.socket.close()
except:
pass"
Without that there is an unavoidable error printing.
py-mine-bot
commented
Feb 15, 2022
|
|
||
| status_res = server.status(retries=1) | ||
| data['version'] = status_res.version.name | ||
| data['protocol'] = status_res.version.protocol |
There was a problem hiding this comment.
Authored by kevinkjt2000
Nov 15, 2019
Outdated (history rewrite) - original diff
@@ -70,6 +71,43 @@ def status():
)
+@cli.command(short_help="all available server information in json")
+def json():
+ """
+ Prints server status and query in json. Supported by all Minecraft
+ servers that are version 1.7 or higher.
+ """
+ data = {'online': False}
+ # Build data with responses and quit on exception
+ try:
+ ping_res = server.ping()
+ data['online'] = True
+ data['ping'] = ping_res
+ data = {
+ 'online': True,
+ 'ping': ping_res,
+ }I notice that 'online' and 'ping' are repeated above. Please remove lines 86-89, since lines 84-85 already do the same.
Should be released now as version 2.3.0. Thanks again for contributing! |
py-mine-bot
added
the
Github Import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #51 the code was rebased then changed to use
json.dumps. Tested successfully on some servers from minecraftservers.org (when ping worked, otherwise it showed{"online": false})