-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating font caching mechanism + support for .pkl font files definitions #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 90.38% 90.58% +0.20%
==========================================
Files 20 20
Lines 5926 5885 -41
Branches 1192 1182 -10
==========================================
- Hits 5356 5331 -25
+ Misses 346 331 -15
+ Partials 224 223 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Only one small remark on a test.
Thansk for the review @Spenhouet! |
cf. #345
Checklist:
The GitHub pipeline is OK (green)
Unit tests are covering the code added / modified by this PR
This PR is ready to be merged
[NA] In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md