Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating font caching mechanism + support for .pkl font files definitions #347

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Mar 4, 2022

cf. #345

Checklist:

  • The GitHub pipeline is OK (green)

  • Unit tests are covering the code added / modified by this PR

  • This PR is ready to be merged

  • [NA] In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #347 (95ee573) into master (6dedf61) will increase coverage by 0.20%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   90.38%   90.58%   +0.20%     
==========================================
  Files          20       20              
  Lines        5926     5885      -41     
  Branches     1192     1182      -10     
==========================================
- Hits         5356     5331      -25     
+ Misses        346      331      -15     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
fpdf/template.py 93.23% <ø> (ø)
fpdf/fpdf.py 85.87% <77.27%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dedf61...95ee573. Read the comment docs.

Copy link

@Spenhouet Spenhouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Only one small remark on a test.

test/fonts/test_add_font.py Outdated Show resolved Hide resolved
@Lucas-C
Copy link
Member Author

Lucas-C commented Mar 5, 2022

Thansk for the review @Spenhouet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using pickle - deprecating the font caching mechanism + .pkl font files definitions parsing
2 participants