Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: LineBreaks.md. multi_cell() page break clarification. #572

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

MildlyOffensive
Copy link

…lti_cell(). Some people have had difficulty determining if a multi_cell() would result in a line break prior to inserting the multi_cell() dating back to the old pyfpdf.

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

…lti_cell(). Some people have had difficulty determining if a multi_cell() would result in a line break prior to inserting the multi_cell() dating back to the old pyfpdf.
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 94.05% // Head: 94.05% // No change to project coverage 👍

Coverage data is based on head (b6d8f62) compared to base (637fdcd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          23       23           
  Lines        6138     6138           
  Branches     1137     1137           
=======================================
  Hits         5773     5773           
  Misses        189      189           
  Partials      176      176           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C Lucas-C merged commit 4bcd455 into py-pdf:master Oct 4, 2022
@Lucas-C
Copy link
Member

Lucas-C commented Oct 4, 2022

Thank you for this clarification @MildlyOffensive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants