Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encryption with hyperlink bug #675

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

andersonhc
Copy link
Collaborator

@andersonhc andersonhc commented Jan 30, 2023

Fix #672

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • [NA] In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 94.07% // Head: 93.97% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (0d52289) compared to base (0bf0e3e).
Patch coverage: 98.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   94.07%   93.97%   -0.10%     
==========================================
  Files          26       26              
  Lines        6731     6741      +10     
  Branches     1194     1198       +4     
==========================================
+ Hits         6332     6335       +3     
- Misses        230      236       +6     
- Partials      169      170       +1     
Impacted Files Coverage Δ
fpdf/syntax.py 87.50% <92.30%> (-5.36%) ⬇️
fpdf/actions.py 91.22% <100.00%> (+1.43%) ⬆️
fpdf/annotations.py 98.64% <100.00%> (ø)
fpdf/output.py 96.85% <100.00%> (ø)
fpdf/prefs.py 100.00% <100.00%> (ø)
fpdf/sign.py 100.00% <100.00%> (ø)
fpdf/transitions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @andersonhc!

Would you mind adding an entry for this fix in CHANGELOG.md please?

fpdf/syntax.py Outdated Show resolved Hide resolved
@Lucas-C Lucas-C merged commit 6b0aab8 into py-pdf:master Jan 30, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Jan 30, 2023

Thank you @andersonhc!
Merged 😊

@andersonhc andersonhc deleted the encryption-bug branch January 30, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_encryption breaks URL links
2 participants