DEP: Deprecate PdfMerger #1866
Merged
DEP: Deprecate PdfMerger #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 93.42% 93.53% +0.11%
==========================================
Files 34 34
Lines 6632 6623 -9
Branches 1302 1295 -7
==========================================
- Hits 6196 6195 -1
+ Misses 284 281 -3
+ Partials 152 147 -5
☔ View full report in Codecov by Sentry. |
|
@MartinThoma |
MartinThoma
reviewed
Jun 3, 2023
| @@ -522,13 +514,13 @@ def _write_dests(self) -> None: | |||
| raise RuntimeError(ERR_CLOSED_WRITER) | |||
| for named_dest in self.named_dests: | |||
| page_index = None | |||
| if "/Page" in named_dest: | |||
| if "/Page" in named_dest: # deprecated | |||
There was a problem hiding this comment.
Why did you add those comments?
There was a problem hiding this comment.
I've checked in coverage which lines where not covered, with the objective to get 100% for this file
|
Very nice! I marked it as "ready for review". Seems good to go to me. I'm just curious about the |
|
when deprecated, _merger.py should dissapear or at least will be strongly reduced |
MartinThoma
added a commit
that referenced
this pull request
Jun 4, 2023
Deprecations (DEP) - Deprecate PdfMerger (#1866) Bug Fixes (BUG) - Ignore UTF-8 decode errors (#1865) Robustness (ROB) - Handle missing /Type entry in Page tree (#1859) [Full Changelog](3.9.0...3.9.1)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1824