Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC: Avoid endless recursion of reading damaged PDF file #2093

Merged
merged 1 commit into from
Aug 18, 2023
Merged

SEC: Avoid endless recursion of reading damaged PDF file #2093

merged 1 commit into from
Aug 18, 2023

Conversation

exiledkingcc
Copy link
Contributor

@exiledkingcc exiledkingcc commented Aug 17, 2023 •
edited by MartinThoma
Loading

Fixes #140

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ab320c) 94.17% compared to head (763c155) 94.18%.

❗ Current head 763c155 differs from pull request most recent head a84afca. Consider uploading reports for the commit a84afca to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   94.17%   94.18%           
=======================================
  Files          41       41           
  Lines        7387     7389    +2     
  Branches     1458     1459    +1     
=======================================
+ Hits         6957     6959    +2     
  Misses        267      267           
  Partials      163      163
Files Changed Coverage Δ
pypdf/_reader.py 91.71% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma added the nf-security Non-functional change: Security label Aug 18, 2023
@MartinThoma MartinThoma changed the title BUG: avoid endless recursion of reading damaged pdf file SEC: Avoid endless recursion of reading damaged PDF file Aug 18, 2023
@MartinThoma MartinThoma merged commit d224430 into py-pdf:main Aug 18, 2023
14 checks passed
@MartinThoma
Copy link
Member

Thank you 🙏

MartinThoma added a commit that referenced this pull request Aug 20, 2023
@MartinThoma
REL: 3.15.2
89eb626 
## What's new

### Security (SEC)
-  Avoid endless recursion of reading damaged PDF file (#2093)

### Performance Improvements (PI)
-  Re-use content stream (#2101)

### Maintenance (MAINT)
-  Make ParseError inherit from PyPdfError (#2097)

[Full Changelog](3.15.1...3.15.2)
@exiledkingcc exiledkingcc deleted the fix-140 branch August 22, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pubpub-zz pubpub-zz pubpub-zz approved these changes

Assignees
No one assigned
Labels
nf-security Non-functional change: Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: maximum recursion depth exceeded
3 participants
@exiledkingcc @MartinThoma @pubpub-zz