MAINT: Remove duplicate warnings imports #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
commented
May 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 77.19% 77.25% +0.05%
==========================================
Files 17 17
Lines 4328 4326 -2
Branches 819 819
==========================================
+ Hits 3341 3342 +1
+ Misses 812 809 -3
Partials 175 175
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
May 22, 2022
Bug Fixes (BUG): - Incorrectly show deprecation warnings on internal usage (#887) Maintenance (MAINT): - Add stacklevel=2 to deprecation warnings (#889) - Remove duplicate warnings imports (#888) Full Changelog: 1.28.0...1.28.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a handful of places where
warningsmodule was being double imported (once at the top-level and once within a method), leaving in place just the top-level import.