BUG: Fix deprecation warning on using PdfMerger #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 77.21% 77.12% -0.10%
==========================================
Files 17 17
Lines 4328 4328
Branches 820 820
==========================================
- Hits 3342 3338 -4
- Misses 811 815 +4
Partials 175 175
Continue to review full report at Codecov.
|
|
oO ... I'm sorry 🙈 And thank you so much for taking care of it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
PR fixes a deprecation warning being raised when trying to use the
PdfMergerclass. This was a regression of #887 caused by #889 which reversed the changes done to thePyPDF2/merger.pymodule so that it once again used the deprecated user-facingisStringmethod as opposed to the internal_isStringmethod. Additionally, I fixed the deprecation warning raised by referencingreader.namedDestinationsas opposed toreader.named_destinations.