-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sklearn 1.2 #712
Enable sklearn 1.2 #712
Conversation
f6170f2
to
8814200
Compare
8814200
to
8398ccf
Compare
Given that we are trying to support multiple sklearn versions with our package, in the future should we consider testing across multiple sklearn versions as well? Because right now our tests only check if our package works with the latest compatible version of sklearn right? |
Should we make a minor update to the cate_treatment_names docstrings which currently say Update to something like |
Also similar thing in _set_transformed_treatment_names in TreatmentExpansionMixin |
Yes, systematically testing against a wider range of dependencies has long been something we've wanted to support, but our test matrix is already quite large. This is perhaps something that would be better addressed by nightly tests, which we could add when moving over to GitHub Actions. But also note that Python 3.7 support was dropped by scikit-learn a while ago, so we're still testing against scikit-learn 1.0.3 when we run our Python 3.7 tests. |
I'm going to defer the docstring updates to a subsequent PR, because there are some additional changes to our name propagation logic that I think would simplify things and which can all go in together. |
Fixes #711