Minor fixes #750
Merged
Minor fixes #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
1086075
to
ab9c749
Compare
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
faaa4bc
to
a00c4a6
Compare
fverac
reviewed
May 5, 2023
| @@ -224,7 +226,7 @@ jobs: | |||
| steps: | |||
| - run: exit 1 | |||
| name: At least one check failed or was cancelled | |||
| if: ${{ !(success()) }} | |||
| if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }} | |||
There was a problem hiding this comment.
I don't understand the reason for the change here, could you explain?
There was a problem hiding this comment.
At the step level, success is checking that each previous step succeeded, not that the required jobs succeeded, see e.g. https://github.com/py-why/EconML/actions/runs/4461230788/jobs/7835479732
fverac
reviewed
May 5, 2023
| @@ -899,7 +899,7 @@ def score(self, Y, T, X=None, W=None, Z=None, sample_weight=None, groups=None): | |||
| nuisances = [np.zeros((n_iters * n_splits,) + nuis.shape) for nuis in nuisance_temp] | |||
|
|
|||
| for it, nuis in enumerate(nuisance_temp): | |||
| nuisances[it][i * n_iters + j] = nuis | |||
| nuisances[it][j * n_iters + i] = nuis | |||
There was a problem hiding this comment.
Should we link this to the inciting issue.
There was a problem hiding this comment.
The name of that commit mentions it, and I'll rebase rather than squash when merging so that it will be maintained.
fverac
approved these changes
May 5, 2023
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
a00c4a6
to
99a3ebd
Compare
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
kbattocchi
force-pushed
the
kebatt/minorFixes
branch
from
99a3ebd
to
4e1845b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.