Raise threshold to lower the failure rate for rootpehe value assertion. #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kgao
commented
Apr 12, 2024
•
kgao
commented
- This change could lower the failure rate from 4% to Near 0%
Signed-off-by: kgao <kevin.leo.gao@gmail.com>
kbattocchi
requested changes
Apr 19, 2024
Signed-off-by: kgao <kevin.leo.gao@gmail.com>
Signed-off-by: kgao <kevin.leo.gao@gmail.com>
kbattocchi
approved these changes
May 7, 2024
kgao
changed the title
gdaiha
pushed a commit
to gdaiha/EconML
that referenced
this pull request
May 10, 2024
Increase sample size to reduce errors Signed-off-by: kgao <kevin.leo.gao@gmail.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
gdaiha
pushed a commit
to gdaiha/EconML
that referenced
this pull request
May 10, 2024
Increase sample size to reduce errors Signed-off-by: kgao <kevin.leo.gao@gmail.com> Signed-off-by: Gabriel Daiha <gabriel.alves@picpay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.