auto identify the effect modifier columns for `effect' method for EconML estimators #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
bloebp
approved these changes
Nov 16, 2023
bloebp
pushed a commit
that referenced
this pull request
Nov 28, 2023
…nML estimators (#1061) * auto identify the effect modifier columns Signed-off-by: Amit Sharma <amit_sharma@live.com> * fixed formatting errors Signed-off-by: Amit Sharma <amit_sharma@live.com> --------- Signed-off-by: Amit Sharma <amit_sharma@live.com>
|
Hi @amit-sharma @bloebp is this fix available in DoWhy 0.11.1? |
|
yes, it is available in 0.11.1 |
|
Great news, thanks for the update @amit-sharma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038.
In v0.10, the user is expected to provide only the effect modifiers columns, which can cause issues if the order of effect modifiers is not correct.
So we revert to v0.8 behavior where the user is only expected to pass the dataframe.