Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing VERSION file when installing via setup.py #93

Merged
merged 2 commits into from
Dec 14, 2019

Conversation

Lnk2past
Copy link
Contributor

Fixes #92

  • Moves the VERSION file into the dowhy package
  • Updates the path to this file in setup.py, dowhy/__init__.py, and MANIFEST.in
  • Update setup.py to include the VERSION file in the package

I initially was going to rename the VERSION file to __version__ and include that way (therefore you can just import it), but I figured this might not be what others want, so I figured I would keep things as close to the original intent as I could.

@msftclas
Copy link

msftclas commented Dec 13, 2019

CLA assistant check
All CLA requirements met.

@Lnk2past
Copy link
Contributor Author

Lnk2past commented Dec 13, 2019

To be honest I am not sure if there even needs to be an entry in MANIFEST.in for VERSION, would be good if someone could confirm if that is needed at this point.

@amit-sharma amit-sharma merged commit b503461 into py-why:master Dec 14, 2019
@amit-sharma
Copy link
Member

Thanks @Lnk2past This is excellent! Yeah, I think it's probably not needed now in MANIFEST, but let's keep it like this to verify if the issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version issue from __init__.py
3 participants