-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add the ability to convert a PAG to MAG #93
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
68b9894
Added function for converting pag to mag
6c44b95
Merge branch 'py-why:main' into pag_to_mag
aryan26roy 418330e
refactored code and added skeleton for meek rules
aryan26roy a0943ae
Added meek rules
aryan26roy 8f0daf6
Completed pag_to_mag function
aryan26roy 89ce696
Added first test
aryan26roy ac8cb5e
Bump actions/checkout from 3 to 4 (#94)
dependabot[bot] f5398d9
[ENH] Add the ability to convert a DAG to an MAG (#96)
aryan26roy 183f0bf
Linting
aryan26roy a76bddc
Added information to docstring
aryan26roy 043b872
Added checks for markov equivalent graphs in tests
aryan26roy 0766d6b
Added another test
aryan26roy 4fdaa89
Added CHANGELOG
aryan26roy 9b34e6f
Fixed test
aryan26roy 0825a8f
Using has_edge API
aryan26roy 41fc2ff
Fixed a bug in implementation
aryan26roy 7bec4b8
Added another test
aryan26roy 0a7c1f9
Linting
aryan26roy 7462981
Fixed a bug
aryan26roy 1bc397e
Update pywhy_graphs/algorithms/pag.py
aryan26roy 77fa079
Update pywhy_graphs/algorithms/pag.py
aryan26roy d335367
Added comments to unit tests
aryan26roy 194f663
Cleaned up the docstring
aryan26roy 7cfaa6b
Merge branch 'main' into pag_to_mag
adam2392 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As before, for unit-tests, these are commonly read by other developers, so it's useful to add some comments specifying what the test is actually testing for vs other tests. You can even split this into multiple unit-test functions w/ more descriptive naming if that's easier.
For example:
test_pag_to_mag_when_graph_is_confounded_and...