Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: partner support to metadata parsing #93

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Feb 22, 2024

closes #92

This is a small fix to parse the partners in our issues and then return the value in our model.
NOTE: need to test the full workflow including exporting to yaml before merging this so i'll open as a draft. i suspect i have to add a key somewhere to reorder the data.

Also note that this pr inspired #91 because the code to parse the header is super hard to follow.

@lwasser
Copy link
Member Author

lwasser commented Feb 24, 2024

This is working now BUT the categories are doing something funky --

    - data-retrieval
    - data-extraction
    - data-processing/munging
    - data-deposition
    - data-validation and-testing
    - workflow-automation
    - database-interoperability

will revisit that piece and potential pydantic validators to cleanup.

@lwasser lwasser marked this pull request as ready for review February 25, 2024 01:54
@lwasser lwasser merged commit 042fcb5 into pyOpenSci:main Feb 25, 2024
2 checks passed
@lwasser lwasser deleted the add-partners branch February 25, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: support for astropy and other partners in the parse issue method
1 participant