Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperparameters exposure #13

Closed
gcattan opened this issue Oct 23, 2021 · 5 comments
Closed

Hyperparameters exposure #13

gcattan opened this issue Oct 23, 2021 · 5 comments

Comments

@gcattan
Copy link
Collaborator

gcattan commented Oct 23, 2021

Ok. Like SVC, QuanticSVM should allow to set SVM hyper-parameters in its init.

Originally posted by @qbarthelemy in #2 (comment)

@gcattan
Copy link
Collaborator Author

gcattan commented Nov 19, 2021

Todo list:

  • gamma (SklearnSVM)
  • feature_map (QSVM and VQC)
  • number of shots (QSVM and VQC)
  • optimizer (VQC)
  • variational form (VQC)
  • enforce_spd (QSVM and VQC)
  • number of iteration (QSVM, VQC, SklearnSVM)
  • output normalization (QSVM, VQC, SklearnSVM)
  • L2 regularisation (QSVM, VQC, SklearnSVM)

@qbarthelemy
Copy link
Member

qbarthelemy commented Jan 13, 2022

Can we close this issue?

More generally, do not forget to close issues when PR are merged.

@gcattan
Copy link
Collaborator Author

gcattan commented Jan 13, 2022

Hello,

I was not sure how to manage stories.
There are four parameters to expose again, but I can create child issues and reference them in this one if you prefer.

@gcattan
Copy link
Collaborator Author

gcattan commented Jan 16, 2022

After double-checking, it seems that these last parameters are not accessible directly in the version of qiskit we used.
I think we can safely close this issue and add follow-up for C and max_iter parameters, after #15.

@qbarthelemy
Copy link
Member

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants