-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rapsd fix #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 78.97% 79.22% +0.24%
==========================================
Files 135 136 +1
Lines 9890 9903 +13
==========================================
+ Hits 7811 7846 +35
+ Misses 2079 2057 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @pulkkins , very nice contribution!
I have a super-minor suggestion below, but otherwise looks good to go!
Hi @pulkkins, |
This pull request introduces a fix for Issue #208 and adds tests for the
utils.spectral.rapsd
function.