Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapsd fix #211

Merged
merged 6 commits into from
Jul 16, 2021
Merged

Rapsd fix #211

merged 6 commits into from
Jul 16, 2021

Conversation

pulkkins
Copy link
Member

@pulkkins pulkkins commented Jul 9, 2021

This pull request introduces a fix for Issue #208 and adds tests for the utils.spectral.rapsd function.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #211 (e1141ef) into master (88fa819) will increase coverage by 0.24%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   78.97%   79.22%   +0.24%     
==========================================
  Files         135      136       +1     
  Lines        9890     9903      +13     
==========================================
+ Hits         7811     7846      +35     
+ Misses       2079     2057      -22     
Flag Coverage Δ
unit_tests 79.22% <90.62%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/utils/spectral.py 71.21% <83.33%> (+32.40%) ⬆️
pysteps/tests/test_utils_spectral.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fa819...e1141ef. Read the comment docs.

@dnerini dnerini requested review from loforest and dnerini July 9, 2021 13:56
Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @pulkkins , very nice contribution!
I have a super-minor suggestion below, but otherwise looks good to go!

pysteps/utils/spectral.py Outdated Show resolved Hide resolved
@dnerini dnerini linked an issue Jul 9, 2021 that may be closed by this pull request
@dnerini dnerini merged commit be238b6 into master Jul 16, 2021
@dnerini dnerini deleted the rapsd_fix branch July 16, 2021 14:42
@loforest
Copy link
Member

Hi @pulkkins,
Thanks a lot for this!
I did not have time to review it before being merged.
I briefly looked at it and it all looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rapsd returns a negative frequency for even-sized images
3 participants