Set minimum python version to 3.7 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and maximum version to 3.9
Merged
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 80.78% 80.79%
=======================================
Files 140 140
Lines 10625 10625
=======================================
+ Hits 8583 8584 +1
+ Misses 2042 2041 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aperezhortal
approved these changes
Jan 14, 2022
|
Thanks for updating this! The PR looks ready to merge. I pushed one commit with a minor update to the installation guide, and removing an empty file that seemed unused. |
dnerini
added a commit
to EsmailGhaemi/pysteps
that referenced
this pull request
Jan 15, 2022
* Set minimum python version to 3.7 and maximum version to 3.9 * Update github actions Co-authored-by: Andres Perez Hortal <16256571+aperezhortal@users.noreply.github.com>
dnerini
added a commit
that referenced
this pull request
Jan 15, 2022
* Set minimum python version to 3.7 and maximum version to 3.9 * Update github actions Co-authored-by: Andres Perez Hortal <16256571+aperezhortal@users.noreply.github.com>
dnerini
added a commit
that referenced
this pull request
Jan 15, 2022
* Add initial structure * Add SAL method * Refactor imports * Add MissingOptionalDependency checks * Rename methods * Apply suggestions from code review Co-authored-by: Andres Perez Hortal <16256571+aperezhortal@users.noreply.github.com> * Add basic test * Add interface * More testing * Return a tuple instead of pandas dataframe * Some refactoring * More refactoring * Avoid re-computing the same calculations * Extract sal method into separate module * Minor refactoring * Rename tests * Fix compability issue and rename module * Remove unused argument * Add thr_factor argument * Fix backward compatibility * Rename variable * Fix black * Fix black part 2 * Replace max_precip with quantile95_precip Replace max_precip with quantile95_precip for calculating the threshold. * Convert masked arrays to numpy arrays This avoids problems with nanquantile * Fix skimage backward compatibility * Add bibliography * Compute quantile on wet pixels only * Fix property name * Set fill value in all cases * Make sure that it works with empty inputs Return nan when a score is undefined * Aesthetics * Add no-cache-dir flag * Pin numpy build version to match the one available on conda-forge * Update module name * Pin maximum numpy version * Revert commit 94ea041 * Set minmax=minref Following suggestion from @feldmann-m * Subpress all splits if thr_factor is passed Following suggestion from @feldmann-m * New set of parameters for tstorm * Add option to specifiy the detection quantile * Improve docstrings * Set minimum python version to 3.7 (#253) * Set minimum python version to 3.7 and maximum version to 3.9 * Update github actions Co-authored-by: Andres Perez Hortal <16256571+aperezhortal@users.noreply.github.com> * Add docstring references * Use mamba to setup test environments (#256) * Try using mamba to speedup installing dependencies * Use mamba.bat command for windows Co-authored-by: Esmail Ghaemi <esi@Esmails-Air.fritz.box> Co-authored-by: Esmail Ghaemi <esi@Esmails-MacBook-Air.local> Co-authored-by: Daniele Nerini <daniele.nerini@gmail.com> Co-authored-by: Andres Perez Hortal <16256571+aperezhortal@users.noreply.github.com> Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #252