Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
utils.dimension
will be deprecated in pysteps-v2 (#223), I'm proposing a small update of itsaggregate_fields_space
function to fix a potential error.The snippet below is currently used in both
aggregate_fields_time
andaggregate_fields_space
to select the appropriate aggregation method based on the precipitation unit.While this is indeed the correct approach for the temporal aggregation, it leads to unexpected results* for the spatial counterpart. Hence, I'm suggesting to update
aggregate_fields_space
to use 'mean' aggregation for both 'mm/h' and 'mm' units, as per this PR.(*) illustration: corresponding example from pystep's test suite
Assuming grid cell dimensions in meter and 1 mm = 1 L/m², the total rainfall volume over the complete field is:
while this value is expected to remain unaffected by the aggregation.