Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert maximum/minimum kwargs to max/min and warn #82

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

tlambert03
Copy link
Member

One deprecation warning slipped through after #60 ... for those using maximum and minimum kwargs on their widgets, this will catch those kwargs and turn them to max/min and show a warning

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #82 (2037500) into master (f119363) will decrease coverage by 0.45%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   87.77%   87.31%   -0.46%     
==========================================
  Files          15       15              
  Lines        1619     1632      +13     
==========================================
+ Hits         1421     1425       +4     
- Misses        198      207       +9     
Impacted Files Coverage Δ
magicgui/widgets/_concrete.py 80.46% <28.57%> (-1.75%) ⬇️
magicgui/widgets/_bases.py 89.11% <33.33%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f119363...a008179. Read the comment docs.

Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One could consider aliasing to allow both, but not that big a deal either way. Probably easier just to stick to one for now

@tlambert03
Copy link
Member Author

I think in the medium term, what I might like to do is let backends take a crack at parsing kwargs and returning them into a standardized magicgui form. That might let us "seem to" support both ipywidgets and qt, provided someone has done use_app('qt'). but yeah, something for later

@tlambert03 tlambert03 merged commit 1388f1f into pyapp-kit:master Jan 6, 2021
@tlambert03 tlambert03 deleted the alias-max-min branch January 6, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants