Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added. Artifacts Class #15

Merged
merged 1 commit into from
Oct 10, 2019
Merged

✨ Added. Artifacts Class #15

merged 1 commit into from
Oct 10, 2019

Conversation

KristoferSoler
Copy link
Contributor

No description provided.

@KristoferSoler
Copy link
Contributor Author

All yours @pyasi ^^ Take a look now.

@KristoferSoler
Copy link
Contributor Author

KristoferSoler commented Oct 8, 2019

@pyasi now I see that Emojis doesn't return a Client either as the Annotation. Do you want me to remove that ":return: ...." ?

I can add it to this PR. So never exists 🤐

Copy link
Owner

@pyasi pyasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good call! Added a couple other comments

pybuildkite/buildkite.py Outdated Show resolved Hide resolved
pybuildkite/artifacts.py Show resolved Hide resolved
pybuildkite/artifacts.py Show resolved Hide resolved
pybuildkite/artifacts.py Outdated Show resolved Hide resolved
@pyasi pyasi merged commit 6aa5a71 into pyasi:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants