Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes #77

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Minor bug fixes #77

merged 2 commits into from
Oct 15, 2021

Conversation

Saransh-cpp
Copy link
Member

Changes

  • Divided the values of " .. LAM constant proportional term [s-1]" by 3600
  • Fix weird scientific notations and round the numbers to 5 decimal points (as they are when they are generated)

@Saransh-cpp Saransh-cpp added the bug Something isn't working label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #77 (96d1ec5) into main (72b6837) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          695       698    +3     
=========================================
+ Hits           695       698    +3     
Impacted Files Coverage Δ
bot/utils/degradation_parameter_generator.py 100.00% <ø> (ø)
bot/plotting/comparison_generator.py 100.00% <100.00%> (ø)
bot/plotting/degradation_comparison_generator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890a3a0...96d1ec5. Read the comment docs.

@Saransh-cpp Saransh-cpp merged commit a2f09d9 into main Oct 15, 2021
@Saransh-cpp Saransh-cpp deleted the minor-bug-fixes branch October 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants