Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Outer and Kron #774

Closed
valentinsulzer opened this issue Jan 8, 2020 · 0 comments · Fixed by #777
Closed

Remove Outer and Kron #774

valentinsulzer opened this issue Jan 8, 2020 · 0 comments · Fixed by #777
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

These are now only used for broadcasting and can be replaced by matrix multiplication
valentinsulzer added a commit that referenced this issue Jan 8, 2020
@valentinsulzer
#774 do broadcast with matrix multiplication
2671e95
valentinsulzer added a commit that referenced this issue Jan 8, 2020
@valentinsulzer
#774 remove kron and outer
77fa689
valentinsulzer added a commit that referenced this issue Jan 8, 2020
@valentinsulzer
#774 fix shapes
653d97a
@valentinsulzer valentinsulzer mentioned this issue Jan 8, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Jan 8, 2020
@valentinsulzer
#774 flake8
2188d8b
@valentinsulzer valentinsulzer self-assigned this Jan 9, 2020
valentinsulzer added a commit that referenced this issue Jan 10, 2020
@valentinsulzer
#774 changelop [ci skip]
ff48fcb
valentinsulzer added a commit that referenced this issue Jan 20, 2020
@valentinsulzer
#774 removing duplicates from base solver
e0efb3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 774 remove outer kron pybamm-team/PyBaMM
1 participant
@valentinsulzer