Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#759 add changelog #817

Merged
merged 3 commits into from
Feb 11, 2020
Merged

#759 add changelog #817

merged 3 commits into from
Feb 11, 2020

Conversation

martinjrobins
Copy link
Contributor

Description

Adds changelog for #759

Sorry, forgot to add this!

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #817 into master will increase coverage by 0.04%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   98.14%   98.19%   +0.04%     
==========================================
  Files         180      181       +1     
  Lines        9987    10227     +240     
==========================================
+ Hits         9802    10042     +240     
  Misses        185      185
Impacted Files Coverage Δ
pybamm/expression_tree/exceptions.py 100% <ø> (ø) ⬆️
pybamm/models/submodels/particle/base_particle.py 93.33% <ø> (-3.97%) ⬇️
...dels/submodels/particle/fast/base_fast_particle.py 100% <ø> (ø) ⬆️
pybamm/solvers/casadi_solver.py 100% <100%> (ø) ⬆️
...m/models/full_battery_models/base_battery_model.py 100% <100%> (ø) ⬆️
...odels/full_battery_models/lithium_ion/basic_dfn.py 100% <100%> (ø) ⬆️
...bamm/parameters/standard_parameters_lithium_ion.py 100% <100%> (ø) ⬆️
...ernal_circuit/function_control_external_circuit.py 100% <100%> (ø) ⬆️
...els/submodels/particle/fast/fast_many_particles.py 100% <100%> (ø) ⬆️
...odels/full_battery_models/lithium_ion/basic_spm.py 100% <100%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684a814...95337e0. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been referring to pull requests rather than issues in the changelog

@martinjrobins
Copy link
Contributor Author

We have been referring to pull requests rather than issues in the changelog

I'm happy to change this, but note that this particular breaking change was documented in the issue, not the PR.

@valentinsulzer
Copy link
Member

oh right, good point, leave as is then. Thanks!

@martinjrobins martinjrobins merged commit 4af8ed4 into master Feb 11, 2020
@valentinsulzer valentinsulzer deleted the issue-759-non-smooth-dae branch February 11, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants