Fixed py:array constructor from failing for complex types #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array(const buffer_info &info) constructor fails when given
complex types since their format string is 'Zd' or 'Zf' which has
a length of two and causes an error here:
if (info.format.size() != 1)
throw std::runtime_error("Unsupported buffer format!");
Fixed by allowing format sizes of one and two.
|
Oops, good catch--thanks! |
wjakob
pushed a commit
that referenced
this pull request
Dec 15, 2015
Fixed py:array constructor from failing for complex types
EricCousineau-TRI
added a commit
to EricCousineau-TRI/pybind11
that referenced
this pull request
Nov 19, 2019
…m-cache Remove deregistered objects from the inactive overload cache
EricCousineau-TRI
pushed a commit
to EricCousineau-TRI/pybind11
that referenced
this pull request
Jan 14, 2020
…pybind#35) Reverts pybind#32 This change cause segfaults on Mac CI: RobotLocomotion/drake#12105 This was PR'd against this pybind11 fork and merged, then incorporated into a Drake PR as a commit update. The Drake PR was then reverted in #12105, but the commit was not reverted in pybind11 itself, hence this PR.
sschnug
pushed a commit
to sschnug/pybind11
that referenced
this pull request
Aug 2, 2024
* fix: drop unneeded function * docs: add some notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
array(const buffer_info &info)constructor fails when givencomplex types since their format string is
ZdorZfwhich hasa length of two and causes an error here:
Fixed by allowing format sizes of one and two.