array: set exception message on failure #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
array-failure-message
branch
from
f15ba34
to
781cbc5
Compare
When attempting to get a raw array pointer we return nullptr if given a nullptr, which triggers an error_already_set(), but we haven't set an exception message, which results in "Unknown internal error". Callers that want explicit allowing of a nullptr here already handle it (by clearing the exception after the call).
jagerman
force-pushed
the
array-failure-message
branch
from
781cbc5
to
846389a
Compare
|
No one has commented, and this seems fairly harmless (and fixes a bug, if a somewhat obscure one), so I'll plan to merge this later today. |
|
This was definitely overlooked, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to get a raw array pointer we return nullptr if given a nullptr, which triggers an
error_already_set(), but we haven't set an exception message, which results inUnknown internal error.Callers that want explicit allowing of a
nullptrhere already handle it (by clearing the exception after the call).Fixes #785.