Operator fixes #867
Merged
Operator fixes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python method for /= was set as `__idiv__`, which should be `__itruediv__` under Python 3. This wasn't totally broken in that without it defined, Python constructs a new object by calling __truediv__. The operator tests, however, didn't actually test the /= operator: when I added it, I saw an extra construction, leading to the problem. This commit also includes tests for the previously untested *= operator, and adds some element-wise vector multiplication and division operators.
- realign \ at end of macro lines - use 'using A = B;' rather than 'typedef B A;' - use conditional_t
|
LGTM! |
Python 2 requires both `__div__` and `__truediv__` (and variants) for compatibility with both regular Python 2 and Python 2 under `from __future__ import division`. Without both, division fails in one or the other case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues in
operators.h.The first is that
/=isn't being defined properly under Python 3 (__idiv__is set rather than__itruediv__) so it doesn't get called. Instead Python convertsx /= 3tox = x / 3and ends up create a new object via__truediv__, which probably works in some cases, but isn't correct.The second issue (third commit) is that the
__truediv__(and variants) are needed under Python 2 withfrom __future__ import division, otherwise division will fail (it does not fall back to calling an available__div__). The fix here adds a second binding under the alternate names under Python 2.