Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially deopaque SSL_CTX to support a pyopenssl use case #784

Merged
merged 1 commit into from
Mar 12, 2014
Merged

Partially deopaque SSL_CTX to support a pyopenssl use case #784

merged 1 commit into from
Mar 12, 2014

Conversation

reaperhulk
Copy link
Member

fixes #783

@lvh
Copy link
Member

lvh commented Mar 11, 2014

LGTM! Thanks! Waiting for the unit tests though :)

@jenkins-cryptography
Copy link

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/1108/

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c4d9141 on reaperhulk:fix-783 into cc23b5b on pyca:master.

@reaperhulk
Copy link
Member Author

@lvh, we don't have unit tests for C bindings that we're not consuming ourselves at this time. You'll want to write some unit tests to verify expectations in PyOpenSSL.

lvh added a commit that referenced this pull request Mar 12, 2014
@lvh
Merge pull request #784 from reaperhulk/fix-783
9b0705b 
Partially deopaque SSL_CTX to support a pyopenssl use case

This allows PyOpenSSL to access the "method" field of the SSL_CTX struct, which allows you to see the method of an already existing context. This is useful, for example, for debugging and testing. The relevant PyOpenSSL ticket is pyca/pyopenssl#61.

Fixes #783.
@lvh lvh merged commit 9b0705b into pyca:master Mar 12, 2014
@public public mentioned this pull request Mar 14, 2014
Closed
@reaperhulk reaperhulk deleted the fix-783 branch March 15, 2014 22:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API for accessing SSL_CTX's "method" field
4 participants
@reaperhulk @lvh @jenkins-cryptography @coveralls