Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using M_ASN1_TIME_dup #431

Closed
reaperhulk opened this issue Mar 9, 2016 · 3 comments · Fixed by #435
Closed

Stop using M_ASN1_TIME_dup #431

reaperhulk opened this issue Mar 9, 2016 · 3 comments · Fixed by #435

Comments

@reaperhulk
Copy link
Member

This macro is going away in OpenSSL 1.1.0.

All it really does is ASN1_STRING_dup((const ASN1_STRING *)a) (where a is an ASN1_TIME).

Filing this so we remember to do something about it. On the cryptography side I will make it so the symbol is still available to avoid breaking older pyopenssl.

@hynek
Copy link
Contributor

hynek commented Mar 9, 2016

Seems like we’re using it in only one place:

copy.revocationDate = _lib.M_ASN1_TIME_dup(original.revocationDate)

@reaperhulk
Copy link
Member Author

I can actually entirely replace the _X509_REVOKED_dup implementation with Cryptography_X509_REVOKED_dup. It is available in cryptography 1.2+ only though, so I can't do it unless the required version is getting bumped for the 16.0 release. Is that the plan? I can't remember now. I'll submit a PR that replaces it + bumps the version but feel free to close it if that's not the plan.

@hynek
Copy link
Contributor

hynek commented Mar 10, 2016

We need 1.3 anyway for the missing bindings.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants