Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling caching of pip downloads and wheels #289

Merged
merged 1 commit into from
Jul 3, 2015
Merged

Enabling caching of pip downloads and wheels #289

merged 1 commit into from
Jul 3, 2015

Conversation

alex
Copy link
Member

@alex alex commented Jul 3, 2015

Makes stuff more vroom vroom on travis

Makes stuff more vroom vroom on travis
@hynek
Copy link
Contributor

hynek commented Jul 3, 2015

Are you sure it's working? The build of this PR was just 20s faster than of mine (20 min 25 sec vs 20 min 4 sec).

@reaperhulk
Copy link
Member

First time through cache has no impact since it still has to build it to cache it. But it also looks like the docker images Travis is using don't have pip7 yet so no wheels

@hynek
Copy link
Contributor

hynek commented Jul 3, 2015

Maybe add a pip install -U pip setuptools wheel?

@alex
Copy link
Member Author

alex commented Jul 3, 2015

As always, I prefer to keep orthagonal issues seperate; can we land this as is and do a different patch to upgrade pip if that's what we want?

@hynek
Copy link
Contributor

hynek commented Jul 3, 2015

My understanding is that this change is useless without a newer pip? As in: no caching happens? Or does it mean that it will cache downloads but no wheels?

If the latter, I’m happy to merge.

@alex
Copy link
Member Author

alex commented Jul 3, 2015

downloads are still cached; we're just missing the wheels bit

On Fri, Jul 3, 2015 at 1:43 PM, Hynek Schlawack notifications@github.com
wrote:

My understanding is that this change is useless without a newer pip? As
in: no caching happens? Or does it mean that it will cache downloads but no
wheels?

If the latter, I’m happy to merge.


Reply to this email directly or view it on GitHub
#289 (comment).

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

hynek added a commit that referenced this pull request Jul 3, 2015
Enabling caching of pip downloads and wheels
@hynek hynek merged commit e2a9ad3 into master Jul 3, 2015
@hynek
Copy link
Contributor

hynek commented Jul 3, 2015

vroom vroom

@alex alex deleted the alex-patch-2 branch July 3, 2015 17:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants