Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coverage over the tests #504

Merged
merged 1 commit into from
Jul 6, 2016
Merged

Run coverage over the tests #504

merged 1 commit into from
Jul 6, 2016

Conversation

alex
Copy link
Member

@alex alex commented Jul 4, 2016

No description provided.

@hynek
Copy link
Contributor

hynek commented Jul 4, 2016

Why do we want this? I remember that we took it out at some point.

@alex
Copy link
Member Author

alex commented Jul 4, 2016

It ensures all of our tests are actually run. We do this for cryptography, and I think it's a good idea.

@codecov-io
Copy link

codecov-io commented Jul 4, 2016

Current coverage is 94.99%

Merging #504 into master will increase coverage by 0.69%

@@             master       #504   diff @@
==========================================
  Files             7         16      +9   
  Lines          2033       5593   +3560   
  Methods           0          0           
  Messages          0          0           
  Branches        316        409     +93   
==========================================
+ Hits           1917       5313   +3396   
- Misses           61        198    +137   
- Partials         55         82     +27   

Powered by Codecov. Last updated by 3772611...998de48

@hynek
Copy link
Contributor

hynek commented Jul 4, 2016

so what do we do about all the uncovered code? i believe nobody ever got the memleak tests work?

@alex
Copy link
Member Author

alex commented Jul 4, 2016

idk, what do we do about all the other uncovered code?

On Mon, Jul 4, 2016 at 10:35 AM, Hynek Schlawack notifications@github.com
wrote:

so what do we do about all the uncovered code? i believe nobody ever got
the memleak tests work?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#504 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAADBGpMLnYM9RYOY97GkiHeFwOR4669ks5qSRovgaJpZM4JEY9Y
.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6

@hynek hynek merged commit db8ec13 into master Jul 6, 2016
@alex alex deleted the alex-patch-1 branch July 6, 2016 14:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants