Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: [Breaking] Equilibrium solidification does a binary search for the solidus #7

Merged
merged 8 commits into from
Dec 5, 2019

Conversation

bocklund
Copy link
Collaborator

@bocklund bocklund commented Dec 5, 2019

  • Equilibrium simulations now find the ending temperature automatically, instead of being given an end temperature which may or may not completely solidify. At the end of an equilibrium solidification simulation, a binary search is performed to find the solidus temperature to a specified tolerance for more accurate phase fractions. Closes Equilibrium calculations should search for and stop at the solidus #6
  • [Breaking] the liquid composition input and attribute (x_liquid) SolidificationResult is now a Dict[component name, List[composition]] rather than a List[Dict[Composition state variable, composition]]. The old method is easier in terms of doing further equilibrium calculations by updating condition dicts, but the new method is better for post-processing and plotting, since the last dimension is directly aligned with the temperature dimension.

@bocklund bocklund merged commit d842767 into master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equilibrium calculations should search for and stop at the solidus
1 participant