ENH: [Breaking] Equilibrium solidification does a binary search for the solidus #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x_liquid
) SolidificationResult is now aDict[component name, List[composition]]
rather than aList[Dict[Composition state variable, composition]]
. The old method is easier in terms of doing further equilibrium calculations by updating condition dicts, but the new method is better for post-processing and plotting, since the last dimension is directly aligned with the temperature dimension.