Use Python version to make artifact name unique (1 line) #1899
Conversation
|
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
|
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
|
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
EmilyBourne
changed the title
|
This method has been successfully tested in pyccel/pyccel-cuda |
pyccel-bot
bot
added
Ready_for_review
|
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @jalalium think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄 |
|
/bot run pr_tests |
pyccel-bot
bot
removed
the
Ready_for_review
|
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
The updated version of
upload-artifactmeans that you cannot upload multiple artifacts with the same name. This is problematic on thedevelbranch as the same job is run for multiple Python versions. The easy fix for this is to add the version to the artifact name. Local tests show that the artifacts can still be retrieved with a partial name.