Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for mappings with pdim > ldim #70

Closed
yguclu opened this issue Jun 10, 2020 · 0 comments · Fixed by #119
Closed

Allow for mappings with pdim > ldim #70

yguclu opened this issue Jun 10, 2020 · 0 comments · Fixed by #119
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yguclu
Copy link
Member

yguclu commented Jun 10, 2020

If we call pdim the number of dimensions of the physical domain, and ldim the number of dimensions of our logical domain, we currently cannot handle pdim > ldim because of limitations in SymPDE's Mapping class, but the rest of the code should be able to handle a situation where pdim > ldim as soon as we fix the mapping.

To this end, we can copy and reuse much of the machinery that is implemented in Psydac's classes SymbolicMapping and AnalyticalMapping.
@yguclu yguclu added enhancement New feature or request help wanted Extra attention is needed labels Jun 10, 2020
@yguclu yguclu mentioned this issue Oct 21, 2022
Merged
yguclu added a commit that referenced this issue Oct 21, 2022
@yguclu
Add BasicCallableMapping abstract base class (#119)
1b13c14 
Add new class to module `sympde.topology.mapping`:
   - Require methods `__call__`, `jacobian`, `metric`, `metric_det`, all called with arguments `(*eta)`
   - Require properties `ldim` and `pdim`
   - Require method `jacobian_inv`, which should raise exception if Jacobian matrix is not invertible (e.g. when `ldim < pdim`)
   - Make `CallableMapping` subclass it
   - Spline and NURBS mappings in Psydac will subclass it

Add new method `set_callable_mapping` to symbolic `Mapping` class, in order to attach any object of type `BasicCallableMapping` to it. Psydac will use it to attach spline and NURBS mappings to MappedDomains with undefined Mapping

Further changes:
   - Allow for mappings with `pdim > ldim` (fixes #70)
   - Update library version to 0.16.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BasicCallableMapping abstract base class pyccel/sympde
1 participant
@yguclu