Allow turning off linearity checks in bilinear and linear forms #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguclu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the boolean flag
check_linearityto the constructors ofBilinearFormandLinearForm. The default value isTrue. If set toFalse, the linearity checks are turned off completely. This is different than the existing flagignore_linearity_errors, which controls whether we get a warning or an error when the linearity check fails.The new flag might be useful when the expression in the bilinear or linear form is complicated, because then the linearity check calls the SymPy
Exprmethod.expand(deep=True), which is recursive and can take a very long time.