Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytes rendered wrong #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Dec 18, 2023

fixes: #31

I'm not quite sure what the reason is for the format being specified as binary in JsonSchemaFile, but comparing the implementation in react-jsonschema-form here format=data-url, a detail not specified in the json-schema standard, and it looks like we could use a similar implementation here?

@samuelcolvin
Copy link
Member

I don't think this fixes it, but I might be wrong. We need to fix tests and check all cases are covered.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b7c7cb) 83.66% compared to head (7ec0913) 83.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   83.66%   83.81%   +0.15%     
==========================================
  Files          10       10              
  Lines         661      661              
==========================================
+ Hits          553      554       +1     
+ Misses        108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischaojie
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bytes is currently rendered wrong
2 participants