Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toast component #109

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

Chaoyingz
Copy link
Contributor

fixes #23.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (16abe6a) to head (ac40c31).
Report is 3 commits behind head on main.

❗ Current head ac40c31 differs from pull request most recent head 9436375. Consider uploading reports for the commit 9436375 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #109       +/-   ##
===========================================
- Coverage   95.68%   83.85%   -11.83%     
===========================================
  Files          14       10        -4     
  Lines         950      669      -281     
===========================================
- Hits          909      561      -348     
- Misses         41      108       +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chaoyingz Chaoyingz marked this pull request as ready for review December 20, 2023 13:54
@Chaoyingz
Copy link
Contributor Author

looks like this:
20231220215231_rec_
Please let me know if there are any issues that need fixing or areas for improvement.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much.

Just conflicts need fixing.

So sorry for the long delay.

@Chaoyingz
Copy link
Contributor Author

Conflicts fixed.

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, thanks for resolving conflicts. This is a great feature addition!

@sydney-runkle sydney-runkle merged commit 5469907 into pydantic:main Apr 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast messages
3 participants