Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect computed_field title in Details #306

Merged
merged 1 commit into from
May 30, 2024
Merged

Respect computed_field title in Details #306

merged 1 commit into from
May 30, 2024

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented May 5, 2024

Fixes #186

Copy link

cloudflare-workers-and-pages bot commented May 30, 2024

Deploying fastui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96242cb
Status: ✅  Deploy successful!
Preview URL: https://eee32fce.fastui.pages.dev
Branch Preview URL: https://issue-186.fastui.pages.dev

View logs

@hramezani hramezani changed the title Respect computed_field title in Table and Details Respect computed_field title in Details May 30, 2024
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hramezani!

@sydney-runkle
Copy link
Member

A nice counterpart to #321

@sydney-runkle sydney-runkle merged commit eb51d74 into main May 30, 2024
16 checks passed
@sydney-runkle sydney-runkle deleted the issue-186 branch May 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display should respect field.title
2 participants