-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _WalkCoreSchema
from pydantic into pydantic-core
#615
Labels
Comments
Hopefully, might be faster as well. |
I already tried this, it wasn't any faster because you have to make Python calls to manipulate dicts. |
@adriangb, should we close this as not planned then? |
Yes I’d say so
…On Fri, Aug 16, 2024 at 8:56 PM Sydney Runkle ***@***.***> wrote:
@adriangb <https://github.com/adriangb>, should we close this as not
planned then?
—
Reply to this email directly, view it on GitHub
<#615 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANMPP3NCAKAUOIHTSCFHJTZR2UULAVCNFSM6AAAAABMUPQPJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUGUZTAOJRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/pydantic/pydantic/blob/5049d115edaa4615c45b46ae9362855d0fbc890d/pydantic/_internal/_core_utils.py#L232
I think given the utility we are getting from this and the fact that it is really not specific to pydantic in any way, it makes sense to move to pydantic-core. Not urgent, just creating this as a tracking issue I can reference from a comment in the pydantic source.
The text was updated successfully, but these errors were encountered: