Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _WalkCoreSchema from pydantic into pydantic-core #615

Closed
dmontagu opened this issue May 19, 2023 · 5 comments
Closed

Move _WalkCoreSchema from pydantic into pydantic-core #615

dmontagu opened this issue May 19, 2023 · 5 comments
Labels

Comments

@dmontagu
Copy link
Collaborator

https://github.com/pydantic/pydantic/blob/5049d115edaa4615c45b46ae9362855d0fbc890d/pydantic/_internal/_core_utils.py#L232

I think given the utility we are getting from this and the fact that it is really not specific to pydantic in any way, it makes sense to move to pydantic-core. Not urgent, just creating this as a tracking issue I can reference from a comment in the pydantic source.

@sydney-runkle
Copy link
Member

Hopefully, might be faster as well.

@adriangb
Copy link
Member

I already tried this, it wasn't any faster because you have to make Python calls to manipulate dicts.

@adriangb
Copy link
Member

#1099

@sydney-runkle
Copy link
Member

@adriangb, should we close this as not planned then?

@adriangb
Copy link
Member

adriangb commented Aug 17, 2024 via email

@sydney-runkle sydney-runkle closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants