Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uuid): validation from string #1172

Merged

Conversation

JeanArhancet
Copy link
Contributor

@JeanArhancet JeanArhancet commented Jan 25, 2024

Change Summary

Fix UUID4 validation from string

Related issue number

fix #1164

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #1172 will improve performances by 22.96%

Comparing JeanArhancet:fix/uuid4-validation-from-string (19d4b7e) with main (8be45e6)

Summary

⚡ 2 improvements
✅ 144 untouched benchmarks

Benchmarks breakdown

Benchmark main JeanArhancet:fix/uuid4-validation-from-string Change
test_core_str 38.8 µs 31.7 µs +22.67%
test_core_future_str 39.5 µs 32.1 µs +22.96%

@JeanArhancet
Copy link
Contributor Author

please review

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks correct to me 👍

@davidhewitt davidhewitt merged commit 758bc51 into pydantic:main Jan 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID4 validation from string not strict enough
3 participants